Skip to content

Feature: update new version of dav_subspace with higher performance #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 16, 2024
Merged

Feature: update new version of dav_subspace with higher performance #5199

merged 10 commits into from
Oct 16, 2024

Conversation

@dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Sep 30, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

mohanchen
mohanchen reviewed Oct 8, 2024
View reviewed changes
@mohanchen mohanchen added the Performance Issues related to fail running ABACUS label Oct 8, 2024
@dyzheng dyzheng requested a review from mohanchen October 11, 2024 08:28
mohanchen
mohanchen reviewed Oct 15, 2024
View reviewed changes
@mohanchen mohanchen merged commit a5c35d9 into deepmodeling:develop Oct 16, 2024
14 checks passed
@Cstandardlib Cstandardlib mentioned this pull request Oct 29, 2024
Closed
9 tasks
@maki49 maki49 mentioned this pull request Oct 31, 2024
Closed
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
@dyzheng @pre-commit-ci-lite @Fisherd99
Feature: update new version of dav_subspace with higher performance (d…
91058cd 
…eepmodeling#5199)

* Feature: update new version of dav_subspace

* Fix: UnitTest error

* [pre-commit.ci lite] apply automatic fixes

* Fix: UnitTest HSolver_PW

* Fix: comments in PR

* Fix: error in UT

---------

Co-authored-by: dyzheng <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanchen mohanchen mohanchen approved these changes

+1 more reviewer

@haozhihan haozhihan haozhihan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Performance Issues related to fail running ABACUS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dyzheng @mohanchen @haozhihan